Set Swift clang-linker path#8748
Merged
shahmishal merged 1 commit intoswiftlang:swift/release/6.0from May 20, 2024
Merged
Conversation
Member
Author
|
@swift-ci please test |
etcwilde
force-pushed
the
ewilde/set-swift-clang-linker
branch
2 times, most recently
from
fa8dce4 to
4f4af8f
Compare
Member
Author
|
@swift-ci please test |
|
Can you rebase this PR on |
etcwilde
force-pushed
the
ewilde/set-swift-clang-linker
branch
from
4f4af8f to
1f6bd55
Compare
Member
Author
Done, and here's the cherry-pick: |
Member
Author
|
@swift-ci please test |
Member
Author
|
@swift-ci please test macOS platform |
etcwilde
force-pushed
the
ewilde/set-swift-clang-linker
branch
3 times, most recently
from
577dd53 to
fb64ef9
Compare
The swift driver is picking up the system clang instead of using the clang set in `CC`. The system clang is attempting to use bfd to link Swift, which doesn't work due to Swift's protected symbol usage. Set the swift-driver tool directory based on the location of the clang in use to ensure that we're picking up a consistent set of tools across all of the tests.
etcwilde
force-pushed
the
ewilde/set-swift-clang-linker
branch
from
fb64ef9 to
2c8a5e6
Compare
Member
Author
|
@swift-ci please test |
|
Don't forget to cherry-pick -x this to |
Member
Author
|
@swift-ci please test |
Member
Author
Cherry-pick PR: #8759 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The swift driver is picking up the system clang instead of using the clang set in
CC. The system clang is attempting to use bfd to link Swift, which doesn't work due to Swift's protected symbol usage.rdar://123061492
rdar://127628654